Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating azurerm_search_service from Riviera to the Azure SDK for Go #283

Merged
merged 4 commits into from
Aug 29, 2017
Merged

Migrating azurerm_search_service from Riviera to the Azure SDK for Go #283

merged 4 commits into from
Aug 29, 2017

Conversation

tombuildsstuff
Copy link
Contributor

After doing this migration, it appears the API no longer supports updating, as such the tests failed:

Before:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 120m -run TestAccAzureRMSearchService_
=== RUN   TestAccAzureRMSearchService_importBasic
--- PASS: TestAccAzureRMSearchService_importBasic (75.94s)
=== RUN   TestAccAzureRMSearchService_basic
--- PASS: TestAccAzureRMSearchService_basic (55.20s)
=== RUN   TestAccAzureRMSearchService_updateReplicaCountAndTags
--- FAIL: TestAccAzureRMSearchService_updateReplicaCountAndTags (73.08s)
 testing.go:435: Step 1 error: Error applying: 1 error(s) occurred:

   * azurerm_search_service.test: 1 error(s) occurred:

   * azurerm_search_service.test: search.ServicesClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="Unknown" Message="Service update operation are not allowed at this time RequestId: e452a663-8d80-440b-836e-d981af10bddb"
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm	204.250s

I've updated the tests and the fields to be ForceNew and they're now passing:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 120m -run TestAccAzureRMSearchService_
=== RUN   TestAccAzureRMSearchService_importBasic
--- PASS: TestAccAzureRMSearchService_importBasic (77.21s)
=== RUN   TestAccAzureRMSearchService_importComplete
--- PASS: TestAccAzureRMSearchService_importComplete (97.07s)
=== RUN   TestAccAzureRMSearchService_basic
--- PASS: TestAccAzureRMSearchService_basic (76.16s)
=== RUN   TestAccAzureRMSearchService_complete
--- PASS: TestAccAzureRMSearchService_complete (101.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	352.149s

grubernaut
grubernaut approved these changes Aug 29, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit a685353 into master Aug 29, 2017
@tombuildsstuff tombuildsstuff deleted the search-service branch August 29, 2017 15:29
tombuildsstuff added a commit that referenced this pull request Aug 29, 2017
@tombuildsstuff
Updating to include #283
781bc8e
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @grubernaut